Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add access approval settings resources #7010

Conversation

modular-magician
Copy link
Collaborator

Fixes #6595

Add google_folder_access_approval_settings, google_organization_access_approval_settings, and google_project_access_approval_settings resources.

Release Note Template for Downstream PRs (will be copied)

`google_folder_access_approval_settings`
`google_organization_access_approval_settings`
`google_project_access_approval_settings`

Derived from GoogleCloudPlatform/magic-modules#3828

* add access approval for project, folder, org

* add access approval settings resources

* changes from review comments

* remove description line about repeated entries in list, since its a set and there won't be repeats

* add delete to access approval settings, make enrolled_services required, notification_emails default from api

Signed-off-by: Modular Magician <[email protected]>
@ghost ghost added the size/xxl label Aug 12, 2020
@modular-magician modular-magician merged commit 449d358 into hashicorp:master Aug 12, 2020
@ghost
Copy link

ghost commented Sep 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

access approval settings
1 participant